Skip to content

Move to landscape2 for embed #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

Move to landscape2 for embed #289

merged 1 commit into from
Feb 11, 2025

Conversation

@jmertic
Copy link
Contributor

@jmertic jmertic commented Feb 1, 2025

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 1, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@jmertic jmertic mentioned this pull request Feb 11, 2025
Merged
@alileclerc alileclerc merged commit 778ff54 into prestodb:source Feb 11, 2025
3 checks passed
@alileclerc
Copy link
Collaborator

alileclerc commented Feb 11, 2025

@jmertic looks like this is still broken https://prestodb.io/join/

It currently links to https://landscape.prestodb.io/card-mode?category=presto-foundation-member&grouping=category, is there a new URL it should now map to?

@jmertic
Copy link
Contributor Author

jmertic commented Feb 11, 2025

Hmm - can you point to where the source code for this page is at? I bet there is another embed I need to fix

@alileclerc
Copy link
Collaborator

alileclerc commented Feb 11, 2025

it's hosted in wordpress, so will paste it here:

<iframe src="https://landscape.prestodb.io/card-mode?category=presto-foundation-member&amp;grouping=category&amp;embed=yes&amp;style=borderless&amp;css=http://prestodb.io/static/landscape.css" frameborder="0" id="landscape" scrolling="no" style="width: 1px; min-width: 100%; opacity: 1; visibility: visible; overflow: hidden; height: 1717px;"></iframe>

<script src="https://landscape.openmainframeproject.org/iframeResizer.js"></script>

@jmertic
Copy link
Contributor Author

jmertic commented Feb 11, 2025

Sure thing - can you replace with this?

<div class="col">
          <!-- Landscape embed view -->
          <script src="https://cdnjs.cloudflare.com/ajax/libs/iframe-resizer/4.3.9/iframeResizer.min.js">
          <iframe id="iframe-landscape" src="https://presto.landscape2.io/embed/embed.html?base-path=&classify=category&key=presto-foundation-member&headers=true&category-header=false&category-in-subcategory=false&title-uppercase=false&title-alignment=center&title-font-family=sans-serif&title-font-size=28&style=clean&bg-color=%23ffffff&fg-color=%235d88d6&item-modal=true&item-name=false&size=xl&items-alignment=center&iframe-resizer=true" style="width:100%;height:100%;display:block;border:none;"></iframe>
          <!-- Landscape embed item details view -->
          <!-- NOTE: the script and the iframe below should only be added once, even when adding multiple embed views to the page -->
          <script src="https://presto.landscape2.io/embed/embed-item.js"></script>
          <iframe id="embed-item" src="https://presto.landscape2.io/embed/embed-item.html" style="width:100%;height:100%;display:block;border:none;position:fixed;top:0;bottom:0;left:0;right:0;z-index:2147483647;display:none;"></iframe>
          <script>
            iFrameResize({ }, '#iframe-landscape');
          </script>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alileclerc alileclerc alileclerc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmertic @alileclerc